Skip to content

Commit

Permalink
make comments better
Browse files Browse the repository at this point in the history
  • Loading branch information
tsullivan committed Apr 10, 2020
1 parent 619bcb4 commit 1339af9
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions x-pack/plugins/reporting/server/config/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,8 @@
import { schema, TypeOf } from '@kbn/config-schema';
import moment from 'moment';

/*
* NOTE dynamic defaults are processed in the createConfig$ function
*/

const KibanaServerSchema = schema.object({
hostname: schema.maybe(
// default value is dynamic
schema.string({
validate(value) {
if (value === '0') {
Expand All @@ -33,7 +28,7 @@ const KibanaServerSchema = schema.object({
},
})
),
});
}); // default values are all dynamic in createConfig$

const QueueSchema = schema.object({
indexInterval: schema.string({ defaultValue: 'week' }),
Expand Down Expand Up @@ -90,7 +85,7 @@ const CaptureSchema = schema.object({
schema.boolean({ defaultValue: false }),
schema.maybe(schema.never())
),
disableSandbox: schema.maybe(schema.boolean()), // default value is dynamic
disableSandbox: schema.maybe(schema.boolean()), // default value is dynamic in createConfig$
proxy: schema.object({
enabled: schema.boolean({ defaultValue: false }),
server: schema.conditional(
Expand Down Expand Up @@ -140,7 +135,7 @@ const CsvSchema = schema.object({
const EncryptionKeySchema = schema.conditional(
schema.contextRef('dist'),
true,
schema.maybe(schema.string({ minLength: 32 })), // default value is dynamic
schema.maybe(schema.string({ minLength: 32 })), // default value is dynamic in createConfig$
schema.string({ minLength: 32, defaultValue: 'a'.repeat(32) })
);

Expand Down

0 comments on commit 1339af9

Please sign in to comment.