feat: 🎸 add TriggerContextMapping interface

src/legacy/core_plugins/visualizations/public/embeddable/visualize_embeddable.ts

@@ -303,13 +303,14 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
         }
 
         if (!this.input.disableTriggers) {
-          const triggerId = event.name === 'brush' ? selectRangeTrigger.id : valueClickTrigger.id;
+          const triggerId: 'SELECT_RANGE_TRIGGER' | 'VALUE_CLICK_TRIGGER' =
+            event.name === 'brush' ? selectRangeTrigger.id : valueClickTrigger.id;
           const params: EmbeddableVisTriggerContext = {
             embeddable: this,
             timeFieldName: this.vis.indexPattern.timeFieldName,
             data: event.data,
           };
-          npStart.plugins.uiActions.getTrigger<EmbeddableVisTrigger>(triggerId).exec(params);
+          npStart.plugins.uiActions.getTrigger(triggerId).exec(params);
         }
       })
     );

src/plugins/embeddable/public/bootstrap.ts

@@ -18,15 +18,27 @@
  */
 
 import { UiActionsSetup } from 'src/plugins/ui_actions/public';
+import { Trigger } from '../../ui_actions/public';
 import {
   applyFilterTrigger,
   contextMenuTrigger,
   createFilterAction,
   panelBadgeTrigger,
   selectRangeTrigger,
   valueClickTrigger,
+  EmbeddableVisTrigger,
 } from './lib';
 
+declare module '../../ui_actions/public' {
+  export interface TriggerContextMapping {
+    SELECT_RANGE_TRIGGER: EmbeddableVisTrigger;
+    VALUE_CLICK_TRIGGER: EmbeddableVisTrigger;
+    CONTEXT_MENU_TRIGGER: Trigger;
+    APPLY_FILTER_TRIGGER: Trigger;
+    PANEL_BADGE_TRIGGER: Trigger;
+  }
+}
+
 /**
  * This method initializes Embeddable plugin with initial set of
  * triggers and actions.

src/plugins/ui_actions/public/index.ts

@@ -30,6 +30,7 @@ export { UiActionsServiceParams, UiActionsService } from './service';
 export { Action, createAction, IncompatibleActionError } from './actions';
 export { buildContextMenuForActions } from './context_menu';
 export { Trigger, TriggerContext, TriggerContextParams } from './triggers';
+export { TriggerContextMapping } from './types';
 
 /**
  * @deprecated

src/plugins/ui_actions/public/service/ui_actions_service.ts

@@ -17,7 +17,12 @@
  * under the License.
  */
 
-import { TriggerRegistry, ActionRegistry, TriggerToActionsRegistry } from '../types';
+import {
+  TriggerRegistry,
+  ActionRegistry,
+  TriggerToActionsRegistry,
+  TriggerContextMapping,
+} from '../types';
 import { Action } from '../actions';
 import { Trigger, TriggerContextParams } from '../triggers/trigger';
 import { TriggerInternal } from '../triggers/trigger_internal';
@@ -59,11 +64,13 @@ export class UiActionsService {
     this.triggerToActions.set(trigger.id, []);
   };
 
-  public readonly getTrigger = <T extends Trigger<any, any>>(id: string): TriggerContract<T> => {
-    const trigger = this.triggers.get(id);
+  public readonly getTrigger = <T extends keyof TriggerContextMapping>(
+    triggerId: T
+  ): TriggerContract<TriggerContextMapping[T]> => {
+    const trigger = this.triggers.get(triggerId as string);
 
     if (!trigger) {
-      throw new Error(`Trigger [triggerId = ${id}] does not exist.`);
+      throw new Error(`Trigger [triggerId = ${triggerId}] does not exist.`);
     }
 
     return trigger.contract;
@@ -140,7 +147,7 @@ export class UiActionsService {
     triggerId: string,
     params: TriggerContextParams<T>
   ) => {
-    const trigger = this.getTrigger<T>(triggerId);
+    const trigger = this.getTrigger<any>(triggerId);
     await trigger.exec(params);
   };
 

src/plugins/ui_actions/public/types.ts

@@ -19,7 +19,12 @@
 
 import { Action } from './actions/action';
 import { TriggerInternal } from './triggers/trigger_internal';
+import { Trigger } from './triggers';
 
 export type TriggerRegistry = Map<string, TriggerInternal<any>>;
 export type ActionRegistry = Map<string, Action>;
 export type TriggerToActionsRegistry = Map<string, string[]>;
+
+export interface TriggerContextMapping {
+  [key: string]: Trigger<any, any>;
+}