Skip to content

Commit

Permalink
[NP] Dashboard (#61895)
Browse files Browse the repository at this point in the history
* Remove absoluteToParsedUrl reference in dashboard

* Remove KibanaParsedUrl from visualize

* Fix tests

* Add tests

* Fix saved dashboard

* Fix empty line after resolving conflicts

* Move dashboard to np

* Move migrations back to legacy

* Make it works

* Other fixes

* Move into application folder

* FIx translations

* Make share & home plugins otional

* FIx kbn url tracking, jest tests

* Import from dashboard_constants in FT

* Fix translations order

* Use getStartServices for start plugin deps

* Path fixes

* i18n fix

Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
sulemanof and elasticmachine authored Apr 6, 2020
1 parent 4ab89e9 commit 104b490
Show file tree
Hide file tree
Showing 106 changed files with 732 additions and 1,026 deletions.
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ export default function(kibana) {
'plugins/kibana/discover/legacy',
'plugins/kibana/dev_tools',
'plugins/kibana/visualize/legacy',
'plugins/kibana/dashboard/legacy',
],
app: {
id: 'kibana',
Expand Down

This file was deleted.

28 changes: 0 additions & 28 deletions src/legacy/core_plugins/kibana/public/dashboard/index.ts

This file was deleted.

30 changes: 0 additions & 30 deletions src/legacy/core_plugins/kibana/public/dashboard/legacy.ts

This file was deleted.

32 changes: 0 additions & 32 deletions src/legacy/core_plugins/kibana/public/dashboard/legacy_imports.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
jest.mock(
'ui/chrome',
() => ({
getKibanaVersion: () => '6.3.0',
}),
{ virtual: true }
);

jest.mock(
'ui/notify',
() => ({
toastNotifications: {
addDanger: () => {},
},
}),
{ virtual: true }
);

jest.mock('ui/new_platform');

import { migratePanelsTo730 } from './migrate_to_730_panels';
import { SavedDashboardPanelTo60, SavedDashboardPanel730ToLatest } from '../np_ready/types';
import {
RawSavedDashboardPanelTo60,
RawSavedDashboardPanel610,
Expand All @@ -46,6 +25,8 @@ import {
RawSavedDashboardPanel640To720,
DEFAULT_PANEL_WIDTH,
DEFAULT_PANEL_HEIGHT,
SavedDashboardPanelTo60,
SavedDashboardPanel730ToLatest,
} from '../../../../../../plugins/dashboard/public';

test('6.0 migrates uiState, sort, scales, and gridData', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,11 @@ import {
RawSavedDashboardPanel730ToLatest,
RawSavedDashboardPanel610,
RawSavedDashboardPanel620,
} from '../../../../../../plugins/dashboard/public';

import {
SavedDashboardPanelTo60,
SavedDashboardPanel620,
SavedDashboardPanel630,
SavedDashboardPanel610,
} from '../np_ready/types';
} from '../../../../../../plugins/dashboard/public';

const PANEL_HEIGHT_SCALE_FACTOR = 5;
const PANEL_HEIGHT_SCALE_FACTOR_WITH_MARGINS = 4;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { migrations } from '../../../migrations/';
import { migrations } from '../../../migrations';
import { migrations730 } from './migrations_730';
import {
DashboardDoc700To720,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { Filter, Query } from '../../../../../../plugins/data/public';
import { Filter, Query } from 'src/plugins/data/public';

export interface Pre600FilterQuery {
// pre 6.0.0 global query:queryString:options were stored per dashboard and would
Expand Down

This file was deleted.

This file was deleted.

131 changes: 0 additions & 131 deletions src/legacy/core_plugins/kibana/public/dashboard/np_ready/types.ts

This file was deleted.

Loading

0 comments on commit 104b490

Please sign in to comment.