remove row actions popover

elastic · Jul 17, 2024 · 0c7c4ec · 0c7c4ec
1 parent 9bbf10f
commit 0c7c4ec
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/...es/kbn-elastic-assistant/impl/knowledge_base/knowledge_base_settings_management/index.tsx b/...es/kbn-elastic-assistant/impl/knowledge_base/knowledge_base_settings_management/index.tsx
@@ -57,7 +57,8 @@ export const KnowledgeBaseSettingsManagement: React.FC = React.memo(() => {
     useSettingsUpdater(
       DEFAULT_CONVERSATIONS, // Knowledge Base settings do not require conversations
       DEFAULT_PROMPTS, // Knowledge Base settings do not require prompts
-      false // Knowledge Base settings do not require conversations
+      false, // Knowledge Base settings do not require conversations
+      false // Knowledge Base settings do not require prompts
     );
 
   const handleSave = useCallback(

diff --git a/...stant/impl/knowledge_base/knowledge_base_settings_management/use_knowledge_base_table.tsx b/...stant/impl/knowledge_base/knowledge_base_settings_management/use_knowledge_base_table.tsx
@@ -10,10 +10,12 @@ import React, { useCallback } from 'react';
 import { FormattedDate } from '@kbn/i18n-react';
 import { KnowledgeBaseEntryResponse } from '@kbn/elastic-assistant-common';
 import * as i18n from './translations';
-import { RowActions } from '../../assistant/common/components/assistant_settings_management/row_actions';
 import { BadgesColumn } from '../../assistant/common/components/assistant_settings_management/badges';
+import { useInlineActions } from '../../assistant/common/components/assistant_settings_management/inline_actions';
 
 export const useKnowledgeBaseTable = () => {
+  const getActions = useInlineActions<KnowledgeBaseEntryResponse & { isDefault?: undefined }>();
+
   const getColumns = useCallback(
     ({
       onEntryNameClicked,
@@ -67,19 +69,14 @@ export const useKnowledgeBaseTable = () => {
           sortable: ({ createdAt }: KnowledgeBaseEntryResponse) => createdAt,
         },
         {
-          name: i18n.COLUMN_ACTIONS,
-          render: (knowledgeBase: KnowledgeBaseEntryResponse) => (
-            <RowActions<KnowledgeBaseEntryResponse>
-              rowItem={knowledgeBase}
-              onDelete={onDeleteActionClicked}
-              onEdit={onEditActionClicked}
-              isDeletable
-            />
-          ),
+          ...getActions({
+            onDelete: onDeleteActionClicked,
+            onEdit: onEditActionClicked,
+          }),
         },
       ];
     },
-    []
+    [getActions]
   );
   return { getColumns };
 };