Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imperva] Undefined log.file.* fields breaking tests for filestream inputs #8627

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

janvi-elastic
Copy link
Contributor

@janvi-elastic janvi-elastic commented Dec 1, 2023

Type of change

  • Enhancement

What does this PR do?

Issue:

FAILURE DETAILS:
imperva/securesphere logfile:
[0] parsing field value failed: field "log.file.device_id"'s Go type, string, does not match the expected field type: long (field value: 68)
[1] parsing field value failed: field "log.file.inode"'s Go type, string, does not match the expected field type: long (field value: 98)
  • Resolve above issue by updating log.file.* fields to keyword to prevent a field type mismatch error and added new filestream fields .

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/imperva directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image

@janvi-elastic janvi-elastic requested a review from a team as a code owner December 1, 2023 10:40
@elasticmachine
Copy link

elasticmachine commented Dec 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-04T06:53:20.077+0000

  • Duration: 19 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 1, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.814
Classes 100.0% (1/1) 💚 3.814
Methods 100.0% (10/10) 💚 7.74
Lines 79.078% (223/282) 👎 -9.577
Conditionals 100.0% (0/0) 💚

Comment on lines 2 to 5
- version: "0.21.0"
changes:
- description: Adapt fields for changes in file system info.
type: enhancement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- version: "0.21.0"
changes:
- description: Adapt fields for changes in file system info.
type: enhancement
- version: "0.20.1"
changes:
- description: Adapt fields for changes in file system info.
type: bugfix

@@ -1,7 +1,7 @@
format_version: 2.9.0
name: imperva
title: Imperva
version: "0.20.0"
version: "0.21.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: "0.21.0"
version: "0.20.1"

@efd6
Copy link
Contributor

efd6 commented Dec 4, 2023

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@janvi-elastic janvi-elastic requested a review from efd6 December 4, 2023 06:53
@P1llus P1llus merged commit 6162a85 into elastic:main Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[imperva/securesphere] log.file.* fields mapped as long not keyword
5 participants