-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency on elastic-package #791
Conversation
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@mtojek I think we may have already discussed this before so I apologize if I'm repeating the discussion here: For dependency update PRs like this one or #780 or #679 where the only files being touched are Sometimes there are dependency update PRs that also require additional changes beyond |
I admit I forgot about this rule and simply assigned as a reviewer. I apologize for the inconvenience. I think I will have to adjust some log files here as well: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-791/2/tests |
Ha, it's not an inconvenience at all to review such PRs 🙂. I was more wondering if we had even come up with such a rule in the past 🤔. I can't remember any such conversation but my memory is also terrible. |
jenkins run the tests please |
Pinging @elastic/integrations (Team:Integrations) |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
The CI job has done its job correctly, but it can't report it status correctly due to an infrastructure outage. |
* Update dependency on elastic-package * Fix * Fix: stan integration * Fix: aws integration * Fix: azure integration
What does this PR do?
This PR updates dependency on elastic-package, so this fix is included: elastic/elastic-package#290
Related issues
Screenshots