Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format_spec in the kubernetes_otel package to 3.3.0 #11435

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Oct 16, 2024

Change format_spec in the kubernetes_otel package to 3.3.0 as support for content packages is added to 3.3.0.

Related to elastic/package-spec#818

@gbamparop gbamparop requested a review from a team as a code owner October 16, 2024 13:37
@andrewkroh andrewkroh added Integration:kubernetes_otel Kubernetes OpenTelemetry Assets Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Oct 16, 2024
@andrewkroh andrewkroh added the enhancement New feature or request label Oct 16, 2024
@gizas
Copy link
Contributor

gizas commented Oct 16, 2024

/test

@jsoriano
Copy link
Member

CI will keep failing till we merge elastic/elastic-package#2166 and release a new version of elastic-package. Working on this now.

@gizas
Copy link
Contributor

gizas commented Oct 16, 2024

Thank you @jsoriano !

I was ready to say that the exclude_check in validation file was not working for 3.3.0 version

See bash logs
elastic-package build
Build the package
2024/10/16 17:20:08  INFO License text found in "/Users/andreasgkizas/elastic/integrations/LICENSE.txt" will be included in package
2024/10/16 17:20:08  INFO Skipped errors: found 1 validation error:
   1. package with non-stable semantic version and active beta features (enabled in [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]) can't be released as stable version. (PSR00002)
Error: building package failed: invalid content found in built zip package: found 7 validation errors:
   1. item [LICENSE.txt] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]
   2. item [changelog.yml] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]
   3. item [docs] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]
   4. item [img] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]
   5. item [kibana] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]
   6. item [manifest.yml] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]
   7. item [validation.yml] is not allowed in folder [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]

Reverting version to 3.4.0

elastic-package build
Build the package
2024/10/16 17:21:44  INFO License text found in "/Users/andreasgkizas/elastic/integrations/LICENSE.txt" will be included in package
2024/10/16 17:21:44  INFO Skipped errors: found 1 validation error:
   1. package with non-stable semantic version and active beta features (enabled in [/Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip]) can't be released as stable version. (PSR00002)
Package built: /Users/andreasgkizas/elastic/integrations/build/packages/kubernetes_otel-0.0.4.zip
Done

@gbamparop
Copy link
Contributor Author

/test

1 similar comment
@flash1293
Copy link
Contributor

/test

@gbamparop gbamparop enabled auto-merge (squash) October 16, 2024 16:41
@gbamparop
Copy link
Contributor Author

/test

@jsoriano
Copy link
Member

@gbamparop you may need to update the branch to get the latest changes from main.

@gbamparop gbamparop merged commit 7412120 into elastic:main Oct 16, 2024
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-vault-github-plugin-prod

Package kubernetes_otel - 0.0.4 containing this change is available at https://epr.elastic.co/search?package=kubernetes_otel

harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 4, 2025
…1435)

* Update package version

* Update package version and changelog
harnish-elastic pushed a commit to harnish-elastic/integrations that referenced this pull request Feb 5, 2025
…1435)

* Update package version

* Update package version and changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:kubernetes_otel Kubernetes OpenTelemetry Assets Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants