Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Filebeat DaemonSet renders extraInitContainers with toYaml not tpl #490

Closed
ghost opened this issue Feb 18, 2020 · 1 comment · Fixed by #530
Closed

Filebeat DaemonSet renders extraInitContainers with toYaml not tpl #490

ghost opened this issue Feb 18, 2020 · 1 comment · Fixed by #530
Assignees
@flaper87
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Feb 18, 2020 •
edited by ghost
Loading

Chart version:
7.6.0

Kubernetes version:

Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.8-gke.33", GitCommit:"2c6d0ee462cee7609113bf9e175c107599d5213f", GitTreeState:"clean", BuildDate:"2020-01-15T17:47:46Z", GoVersion:"go1.12.11b4", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes provider:
GKE

Helm Version:

Client: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}

Describe the bug:
All other resources that accept extraInitContainers take a string and use the tpl function to render it. The Filebeat DaemonSet, however, renders the input with toYaml, which results in behaviour that is inconsistent.

https://github.com/elastic/helm-charts/search?q=.values.extrainitcontainers&unscoped_q=.values.extrainitcontainers
@GreenKnight15
Copy link
Contributor

Bump +1

@jmlrt jmlrt added the enhancement New feature or request label Mar 19, 2020
@flaper87 flaper87 self-assigned this Mar 19, 2020
flaper87 added a commit that referenced this issue Mar 19, 2020
@flaper87
Accept a string as extraInitContainers value for filebeat
6d13606 
This makes the filebeat chart consistent with the other beats, while
preserving backwards compatibility.

Fixes #490
flaper87 added a commit that referenced this issue Mar 19, 2020
@flaper87
Accept a string as extraInitContainers value for filebeat
dcd5828 
This makes the filebeat chart consistent with the other beats, while
preserving backwards compatibility.

Fixes #490
@flaper87 flaper87 mentioned this issue Mar 19, 2020
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flaper87 flaper87

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept a string as extraInitContainers value for filebeat elastic/helm-charts
3 participants
@flaper87 @GreenKnight15 @jmlrt