Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Add securityContext to keystore container #1195

Closed
ebuildy opened this issue May 20, 2021 · 2 comments · Fixed by #1494
Closed

[elasticsearch] Add securityContext to keystore container #1195

ebuildy opened this issue May 20, 2021 · 2 comments · Fixed by #1494
Labels
elasticsearch enhancement New feature or request triage/stale

Comments

@ebuildy
Copy link
Contributor

ebuildy commented May 20, 2021

Describe the feature:

Currently, only main container have a securityContext configurable via values.yaml (https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml#L223), in order to improve security, initContainer keystore (https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml#L173) should have it too.

Describe a specific use case for the feature:

This is a good thing to match k8S best-practices, especially when using Fairwinds Polaris.
@jmlrt jmlrt added elasticsearch enhancement New feature or request labels Jul 6, 2021
@botelastic
Copy link

botelastic bot commented Oct 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic
Copy link

botelastic bot commented Nov 3, 2021

This issue has been automatically closed because it has not had recent activity since being marked as stale.

@botelastic botelastic bot closed this as completed Nov 3, 2021
ebuildy added a commit to ebuildy/helm-charts that referenced this issue Dec 15, 2021
@ebuildy
[elasticsearch] add keystore container securityContext
2ec295e 
fix elastic#1195 , add a securityContext for the initContainer "keystore". The securityContext is the same than the main container.
@ebuildy ebuildy mentioned this issue Dec 15, 2021
Merged
4 tasks
jmlrt added a commit that referenced this issue Mar 4, 2022
@ebuildy @jmlrt
[elasticsearch] add keystore container securityContext (#1494)
cf4782c 
fix #1195 , add a securityContext for the initContainer "keystore". The securityContext is the same than the main container.

Co-authored-by: jmlrt <[email protected]>
jmlrt added a commit to jmlrt/helm-charts that referenced this issue Mar 4, 2022
@ebuildy @jmlrt
[elasticsearch] add keystore container securityContext (elastic#1494)
38327a0 
fix elastic#1195 , add a securityContext for the initContainer "keystore". The securityContext is the same than the main container.

Co-authored-by: jmlrt <[email protected]>
jmlrt added a commit that referenced this issue Mar 7, 2022
@jmlrt @ebuildy
[elasticsearch] add keystore container securityContext (#1494) (#1601)
39f8423 
fix #1195 , add a securityContext for the initContainer "keystore". The securityContext is the same than the main container.

Co-authored-by: jmlrt <[email protected]>

Co-authored-by: Thomas Decaux <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
elasticsearch enhancement New feature or request triage/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[elasticsearch] add keystore container securityContext ebuildy/helm-charts
2 participants
@ebuildy @jmlrt