Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(action): auto-bump daily and update who notify to #367

Merged
merged 4 commits into from
Jan 12, 2024
Merged

ci(action): auto-bump daily and update who notify to #367

merged 4 commits into from
Jan 12, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 7, 2023 •
edited
Loading

Run more often and at night, so there is no 1 week gap between golang releases and the golang-autobump
Notify in the #ingest-notifications channel.

Question

  • What team shall be pinged in slack?

@v1v v1v requested review from jlind23 and a team December 7, 2023 20:59
@v1v v1v self-assigned this Dec 7, 2023
v1v
v1v commented Dec 7, 2023
View reviewed changes
v1v
v1v commented Dec 7, 2023
View reviewed changes
.github/workflows/bump-golang-1.20.yml Outdated
@@ -21,3 +24,5 @@ jobs:
vaultUrl: ${{ secrets.VAULT_ADDR }}
vaultRoleId: ${{ secrets.VAULT_ROLE_ID }}
vaultSecretId: ${{ secrets.VAULT_SECRET_ID }}
notifySlackChannel: "#ingest-notifications"
messageIfFailure: ":traffic_cone: updatecli failed for `${{ github.repository }}@${{ github.ref_name }}`, `@update-me-with-the-slack-team-to-be-poked` please look what's going on <${{ env.JOB_URL }}|here>"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@v1v v1v mentioned this pull request Dec 8, 2023
Merged
7 tasks
@v1v
Merge remote-tracking branch 'upstream/main' into feature/udpate-gola…
519cce3 
…ng-auto-bump

* upstream/main:
  docs: explain how to update the auto-bump (elastic#368)
@mergify Mergify
Copy link

mergify bot commented Dec 19, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/udpate-golang-auto-bump upstream/feature/udpate-golang-auto-bump
git merge upstream/main
git push upstream feature/udpate-golang-auto-bump

@v1v
Copy link
Member Author

v1v commented Jan 10, 2024

@elastic/ingest-eng-prod , can you please review this PR? 🙏

@alexsapran
Copy link

Hi Victor,

If I understand the ask is what team inside ingest should be notified in case there is a problem with the golang-crossbuild images. I wanted to ack and provide my pov.

My take is the teams dependent on this library should be aware that there is a problem and get notified and try to fix it.

@jlind23 and @roaksoax can comment on which specific teams this should be as I might be wrong and that team is the ingest-eng-prod.

@jlind23
Copy link
Contributor

jlind23 commented Jan 10, 2024

@pierrehilbert and the elastic agent team should be the one notified!

@v1v
Copy link
Member Author

v1v commented Jan 11, 2024

@pierrehilbert and the elastic agent team should be the one notified!

Excellent, what's the slack team?

@pierrehilbert
Copy link

@Agent-team

@v1v v1v requested a review from pierrehilbert January 11, 2024 15:40
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @v1v

@v1v v1v merged commit f2b6d5a into elastic:main Jan 12, 2024
1 check passed
@v1v v1v deleted the feature/udpate-golang-auto-bump branch January 12, 2024 09:08
@v1v v1v mentioned this pull request Jan 12, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
@v1v @mergify
ci(action): auto-bump daily and update who notify to (#367)
9edc0cd 
(cherry picked from commit f2b6d5a)
@v1v
Copy link
Member Author

v1v commented Jan 12, 2024

@Mergifyio backport 1.20

@mergify Mergify
Copy link

mergify bot commented Jan 12, 2024 •
edited
Loading

backport 1.20

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 12, 2024
@v1v @mergify
ci(action): auto-bump daily and update who notify to (#367)
7be9eee 
(cherry picked from commit f2b6d5a)
@mergify mergify bot mentioned this pull request Jan 12, 2024
Merged
v1v added a commit that referenced this pull request Jan 12, 2024
@mergify @v1v
ci(action): auto-bump daily and update who notify to (backport #367) (#…
c97136e 
…375)

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@pierrehilbert pierrehilbert Awaiting requested review from pierrehilbert

Assignees

@v1v v1v

Labels
backport-v1.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @alexsapran @jlind23 @pierrehilbert @elasticmachine