Add flag to ignore commas when parsing. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new flag stops the parser from building arrays automatically when top level elements are separated with commas. This flag converts parsing into an actual no-op, passing through the input unmodified. This mode is necessary when parsing values that may legitimately contain special characters, like secrets.
cmacknz
added
the
Team:Elastic-Agent-Data-Plane
💚 Build Succeeded
Expand to view the summary
Build stats
|
1 task
kvch
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new flag stops the parser from building arrays automatically when
top level elements are separated with commas. This flag converts parsing
into an actual no-op, passing through the input unmodified. This mode is
necessary when parsing values that may legitimately contain special
characters, like secrets.
This is the first step in fixing elastic/beats#29789. A follow up change in beats will follow to start ignoring commas when loading from the keystore.
Draft beats PR with a failing test that will pass with these changes: elastic/beats#31487