Fix nonzero validator to not validate nil array or slices. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fix issue where required or nonzero didn't work on maps.
urso
reviewed
Feb 3, 2020
|
@urso This is ready for another review. |
urso
reviewed
Feb 5, 2020
urso
reviewed
Feb 5, 2020
urso
reviewed
Feb 5, 2020
urso
reviewed
Feb 5, 2020
urso
approved these changes
Feb 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 78.37% 78.02% -0.35%
==========================================
Files 24 24
Lines 2714 2730 +16
==========================================
+ Hits 2127 2130 +3
- Misses 431 444 +13
Partials 156 156
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where the
nonzerovalidator would fail when the array or slice wasnilvalue.This also includes fixes for map types where nonzero or required would not validate them correctly.
Closes #147