Return not containerized if /proc/1/cgroup does not exist #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
reviewed
Mar 18, 2019
andrewkroh
approved these changes
Mar 18, 2019
If we had a changelog in this project, yes. |
|
🤦♂️ Good time to start one? |
Maybe. @andrewkroh what do you think? |
|
Yeah, let's start one. |
|
Ok, let's add it separate from this PR though. I think we'd want to define the format and contents. It's a bit tricky since this project has no releases, which would usually give structure to the changelog as dated sections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check the contents of
/proc/1/cgroupto determine if we are in a container or not. However, this pseudo file will not exist if cgroup is not available, e.g. if it has been explicitly disabled, maybe on a shared system. This PR returnsfalse(i.e. not containerized) if the file does not exist.This has been reported on SO, and we fixed a similar issue in Beats (elastic/beats#3666).