providers/linux/os.go - Get OS info from Manjaro Linux #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manjaro was not working as expected because the DISTRIB_RELEASE value was never used to get the OS version. There also was no OS distribution family for "arch". So this maps Majaro as part of the "arch" family along with Arch Linux itself and Antergos. Added an additional fallback to use the ID_LIKE field in os-release to determine the OS distribution family. I replaced the deprecated io/ioutil with the os package. Fixes elastic#168
andrewkroh
force-pushed
the
bugfix/linux-os-manjaro
branch
from
5f5aeab to
2acb1d6
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manjaro was not working as expected because the
DISTRIB_RELEASEvalue was never used to get the OS version.There was no OS distribution family for "arch". So this maps Majaro as part of the "arch" family along with Arch Linux itself and Antergos.
Added an additional fallback to use the
ID_LIKEfield inos-releaseto determine the OS distribution family.I replaced the deprecated
io/ioutilwith theospackage.Fixes #168