[Visual Refresh] Update floating border on EuiPanel #8270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prevents transparent borders showing on colored full-width content, e.g. for EuiSplitPanel
mgadewoll
force-pushed
the
eui-theme/panel-floating-border-fix
branch
from
2168cd7 to
11d4754
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @mgadewoll |
|
LGTM 👍🏻 Great job, Lene! TestingStorybook (Borealis)Screen.Recording.2025-01-14.at.12.01.33.movStorybook (Amsterdam)Screen.Recording.2025-01-14.at.12.05.00.movEUI Docs (Borealis)Screen.Recording.2025-01-14.at.12.03.45.movEUI Docs (Amsterdam)Screen.Recording.2025-01-14.at.12.06.13.movScreen.Recording.2025-01-14.at.12.15.02.movProduction vs Staging (Amsterdam)Screen.Recording.2025-01-14.at.12.06.13.movScreen.Recording.2025-01-14.at.12.13.09.mov |
acstll
added a commit
to acstll/kibana
that referenced
this pull request
Jan 23, 2025
acstll
added a commit
to acstll/kibana
that referenced
this pull request
Jan 23, 2025
acstll
added a commit
to elastic/kibana
that referenced
this pull request
Jan 30, 2025
`99.0.0-borealis.1` ⏩ `99.1.0-borealis.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- # `@elastic/eui` ## [`v99.1.0`](https://github.com/elastic/eui/releases/v99.1.0) - Updated `EuiColorPalettePicker` - adds `append` to `EuiColorPalettePickerPaletteProps` to support appending custom content to the title ([#8208](elastic/eui#8208)) - Updated font-weight and font-size of `EuiBetaBadge`s to improve legibility ([#8255](elastic/eui#8255)) - Added suppport for `titleColor` variant `warning` on `EuiStat` ([#8278](elastic/eui#8278)) # `@elastic/eui-theme-borealis` ## `v0.0.9` - [Visual Refresh] Support new theme tokens on JSON exports ([#8277](elastic/eui#8277)) - Remap few colors for EuiLoadingSpinner and EuiLoadingChart ([#8276](elastic/eui#8276)) - [Visual Refresh] Update floating border on EuiPanel ([#8270](elastic/eui#8270)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: nickofthyme <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch.
This PR updates the implementation of the floating border on
EuiPanelto fix the issue of the transparent border on light mode showing with colored full-width content (e.g. forEuiSplitPanel)Instead of adding the floating border on the panel element directly, this PR adds a pseudo element for the border.
This will:
QA
Note
To enable Borealis in EUI PR deployments, you'll need to:
eui-experimental-theme-enabled: trueEuiSplitPanel(Storybook, EUI docs) is visible for Borealis only