-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose services on public interface #8
Conversation
I started looking at this and compared it with how other packages do their distribution, such as: I realise that where a bundled version of the code is provided, it built with dependencies externalised, so that e.g. React isn't built-in to react-bootstrap. However, that sort of build is only suitable where you're pulling in React into the global scope, e.g. via a CDN into So a Webpack bundle with React externalised is useful, but not in e.g. Cloud where we're using ES2015 modules throughout. I've therefore re-added the transpiled build step, but I've moved the output to
I noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so we can merge and iterate on this.
Lovely. |
Currently we only expose components as part of the public top level interface, this resolves that. This is merely a build issue we have that didn't exist in the
ui_framework
branch. We can also build on top of this PR to add new exposed functions like the ones discussed in #3, without tainting the component layer.