Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiEmptyPrompt] Create Storybook Stories for
EuiEmptyPrompt
& Import Sass Styles for Components Not Using Emotion #7057[EuiEmptyPrompt] Create Storybook Stories for
EuiEmptyPrompt
& Import Sass Styles for Components Not Using Emotion #7057Changes from all commits
9d93f98
305201a
ca7719b
3365ddd
76dfdf6
924b15b
ea17992
6bb2098
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This story ended up changing too much with the changes implemented. The
PageTemplate
story was fine as-is and in fact shouldn't be too similar to thePlayground
- if it is, what's the point of it?Let's move the
...componentDefaults
to the start of the args and then override args as necessary (e.g.layout="horizontal"
) to get this demo back to parity with where it was / the example on EUI docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the direction to DRY out the defaults caused a little confusion on my part here.