Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect variable usage in SCSS #3991

Merged
merged 5 commits into from
Sep 2, 2020
Merged

Fix incorrect variable usage in SCSS #3991

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23232f1
Update _code_block.scss
nyurik Sep 2, 2020
139c7ad
Update CHANGELOG.md
nyurik Sep 2, 2020
7f58602
Merge branch 'master' into nyurik-patch-1
nyurik Sep 2, 2020
aea1694
Update CHANGELOG.md
nyurik Sep 2, 2020
4e7157e
Update CHANGELOG.md
cchaos Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Fixed type mismatch between `EuiSelectable` options extended via `EuiSelectableOption` and internal option types ([#3983](https://github.com/elastic/eui/pull/3983))
- Fixed `EuiButton` CSS for RTL languages by using `margin-inline-[pos]` instead of `margin-[pos]` ([#3974](https://github.com/elastic/eui/pull/3974))
- Fix server-side rendering of `EuiBreadcrumbs` and `EuiCollapsibleNav` ([#3970](https://github.com/elastic/eui/pull/3970))
- Fix incorrect `euiCodeBlockNameColor` variable usage for `.hljs-name` in SCSS ([#3991](https://github.com/elastic/eui/pull/3991))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there was a release after you made this PR, your Changelog needs to be in the master section above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect changelog file doesn't like me... Or i need another cup of coffee... or both.


## [`28.3.0`](https://github.com/elastic/eui/tree/v28.3.0)

Expand Down
2 changes: 1 addition & 1 deletion src/components/code/_code_block.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
}

.hljs-name {
color: euiCodeBlockNameColor;
color: $euiCodeBlockNameColor;
}

.hljs-type,
Expand Down