Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding type any to the step parameter of EUIFIeldNumber #3561

Closed
wants to merge 10 commits into from

Conversation

shrey
Copy link
Contributor

@shrey shrey commented Jun 4, 2020

Summary

Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [] Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos I don't know why changes from my old pr are showing up, but nw, as they're from the same PR that you merged Old PR
@chandlerprall
Related to issue:- #3550

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Jun 4, 2020

It's because you're using the same branch insteading starting again from the master branch. When we merge PR's we squash the commits into a single one. Github gets confused then and doesn't realize that your old commits were included in that single one. You'll need to fetch upstream, and start a new branch from master.

@shrey shrey closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants