Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EuiBasicTable selection doesn't work as expected when id is 0 #3417

Merged
merged 4 commits into from
May 4, 2020
Merged

Fixed EuiBasicTable selection doesn't work as expected when id is 0 #3417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df670e1
Item id can also be 0
ashikmeerankutty May 1, 2020
bb00fde
Added cl
ashikmeerankutty May 1, 2020
e69f05f
Use != instead
ashikmeerankutty May 4, 2020
b035cb6
Updated cl
ashikmeerankutty May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

**Bug Fixes**

- Fixed `EuiBasicTable` item selection when `id` is `0` ([#3417](https://github.com/elastic/eui/pull/3417))
- Fixed `EuiBadge` `iconOnClick` props makes badge text clickable ([#3392](https://github.com/elastic/eui/pull/3392))
- Added `id` requirement if `label` is used in `EuiRadio` ([#3382](https://github.com/elastic/eui/pull/3382))
- Fixed z-index issue in `EuiDatePicker` where it's popover would sit beneath other DOM siblings that had z-index applied ([#3376](https://github.com/elastic/eui/pull/3376))
Expand Down
5 changes: 4 additions & 1 deletion src/components/basic_table/basic_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,10 @@ export class EuiBasicTable<T = any> extends Component<
const cells = [];

const { itemId: itemIdCallback } = this.props;
const itemId: ItemIdResolved = getItemId(item, itemIdCallback) || rowIndex;
const itemId: ItemIdResolved =
getItemId(item, itemIdCallback) != null
? getItemId(item, itemIdCallback)
: rowIndex;
const selected = !selection
? false
: this.state.selection &&
Expand Down