Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a11y testing for EuiFacet #3097

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fixed a11y testing for EuiFacet #3097

merged 1 commit into from
Mar 16, 2020

Conversation

anishagg17
Copy link
Contributor

Summary

makes progress on #2679

navigation

  • facet

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately~
  • Checked for accessibility including keyboard-only and screenreader modes
    - [ ] A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myasonik
Copy link
Contributor

jenkins test this

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI comes back green, looks good to me

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3097/

@cchaos cchaos changed the title fixed a11y testing for facet Fixed a11y testing for EuiFacet Mar 16, 2020
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@cchaos cchaos merged commit 43f4ac7 into elastic:master Mar 16, 2020
@anishagg17 anishagg17 deleted the facet branch March 17, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants