Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added axe tests to form controls, error boundaries and inner text doc pages #3096

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Added axe tests to form controls, error boundaries and inner text doc pages #3096

merged 4 commits into from
Mar 24, 2020

Conversation

mridulgogia
Copy link
Contributor

@mridulgogia mridulgogia commented Mar 16, 2020 •
edited by myasonik
Loading

Summary

Makes progress on #2679
Automated Axe testing

Checklist

Forms

  • Form control

Utilities

  • Error Boundary
  • Inner Text

-[ ] Check against all themes for compatibility in both light and dark modes

  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myasonik
Copy link
Contributor

Hey @mridulgogia! Thanks for this PR!

There's already a PR in progress that will supersede the DataGrid pages you added. Could you remove those from your PR and then we can review just the new pages you have added here?

Thanks!

@myasonik myasonik mentioned this pull request Mar 16, 2020
Closed
26 tasks
@myasonik
Copy link
Contributor

jenkins test this

@cchaos
Copy link
Contributor

cchaos commented Mar 18, 2020

Jenkins test this

cchaos
cchaos suggested changes Mar 18, 2020
View reviewed changes
src-docs/src/views/form_controls/prepend_append.js Outdated Show resolved Hide resolved
src-docs/src/views/inner_text/inner_text.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3096/

@mridulgogia mridulgogia requested a review from cchaos March 24, 2020 19:34
myasonik
myasonik approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

snide
snide approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified changes were made and double checked. Merging.

@snide snide changed the title Added axe test to more components Added axe test to form controls, error boundries and inner text doc pages Mar 24, 2020
@snide snide changed the title Added axe test to form controls, error boundries and inner text doc pages Added axe tests to form controls, error boundaries and inner text doc pages Mar 24, 2020
@snide snide merged commit dcbcccc into elastic:master Mar 24, 2020
@snide
Copy link
Contributor

snide commented Mar 24, 2020

Thanks for the help @mridulgogia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@myasonik myasonik myasonik approved these changes

@cchaos cchaos Awaiting requested review from cchaos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mridulgogia @kibanamachine @myasonik @cchaos @snide