Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved utils helpers(useColorPicker) to src/services #2918

Closed
wants to merge 1 commit into from

Conversation

Dilshaad21
Copy link

@Dilshaad21 Dilshaad21 commented Feb 25, 2020

Summary

Summarize your PR. If it includes design elements include a screenshot or gif.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
073c91c

Please, read and sign the above mentioned agreement if you want to contribute to this project

@anishagg17
Copy link
Contributor

@Dilshaad21 please make a change in changelog.md

@thompsongl
Copy link
Contributor

Thanks for your effort, @Dilshaad21

We're happy to see you want to contribute to EUI, so here are a couple notes:

  • Be sure to sign the CLA. See the comment from the cla-checker-service in the thread above.
  • Be sure to fully complete the relevant items in the PR summary template, such as adding a description with issue references and marking checklist items.
  • Documenting your changes and PRs really helps us review faster and ensure that EUI maintains consistency from person to person. See the contributing guidelines for details.

For this PR specifically, we'd want to move to a different src/services directory (confusing, I know). [eui-root]/src-docs is for documentation only. We want to be able to use this hook from [eui-root]/src, so a new file somewhere in [eui-root]/src/services is a better location.

@thompsongl
Copy link
Contributor

@Dilshaad21 Checking in. Do you plan on updating this PR?

If you're still interested in this issue, some changes were recently made in #2850 that will impact your work.

If not, let us know and we'll reassign the issue.

@anishagg17 anishagg17 mentioned this pull request Mar 13, 2020
9 tasks
@thompsongl
Copy link
Contributor

#3067 addresses the same issue and will soon be merging

@thompsongl thompsongl closed this Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants