-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug in datagrid where Hide fields columns were cached #2725
Fixed bug in datagrid where Hide fields columns were cached #2725
Conversation
CI failure, but I get this locally also |
Apparently our version of (jest|jest-babel|@babel/preset-typescript|something) doesn't support the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Confirmed it fixes the problem using the test case in the issue
jenkins test this |
@thompsongl I renamed the hook to |
Summary
Fixes #2606
EuiDataGrid
where an updated column list was not reflected in the "Hide fields" popoveruseResettingState
custom hook, a pattern I've used a couple places and decided to formalize for this (open to better name suggestions)/cc @walterra
Checklist
- [ ] Check against all themes for compatability in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes