Added missing union type for EuiPageContent

[Drakota]

Summary

I added the HTMLAttributes<HTMLDivElement> type to EuiPageContent, because it seemed to be missing.

I've noticed this because I tried to use the style prop, but it wasn't available and I had to //@ts-ignore the component.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[Drakota]

CLA signed 😊

[chandlerprall]

Good catch, and thanks for the PR!

EuiPanel forwards the ...rest onto either a button or div element depending on if the onClick prop is present, which makes this typing incomplete. The distinction in props exists in EuiPanel line 55, but that definition isn't exported. Instead of adding the HTMDivElement props in page/index.d.ts it should export the full types from EuiPanel.

To sum it up, a better change is to rename the export at EuiPanel:55 to EuiPanelProps, and the existing EuiPanelProps at EuiPanel:15 to the generic Props, while removing that export.

[Drakota]

Hey @chandlergibb,

I understand what you're saying and updated my pull request to reflect the necessary changes. 😃

Feel free to tell me if anything is missing.

[chandlerprall]

Changes LGTM, pulled to build & test the typescript changes locally, tested the generated eui.d.ts in Kibana and didn't see any issues.

[chandlerprall]

@Drakota one more request: an entry to CHANGELOG.md's top master section with a quick description of this bug fix, something like "Fixed EuiPanelProps type definition"

[chandlerprall]

jenkins test this

[chandlerprall]

jenkins test this

[Drakota]

I've added the CHANGELOG entry.
The Jenkins build failing seemed to be from the file not being prettified so I've fixed that as well.

[chandlerprall]

Thanks again, @Drakota !