Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset negative margin for max width inside container for super date picker #2236

Merged
merged 6 commits into from
Aug 29, 2019
Merged

Offset negative margin for max width inside container for super date picker #2236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5536f7f
offset negative margin for max width inside container
shahzad31 Aug 16, 2019
53e59cc
update change log
shahzad31 Aug 16, 2019
074a43c
use constant for px value
shahzad31 Aug 16, 2019
0b23f6d
handled no update button and refresh only button scenerios
shahzad31 Aug 28, 2019
7897f54
Merge branch 'master' into fix/issue-2225-superdatepicker-leaves-unnc…
shahzad31 Aug 28, 2019
f008bf5
Update CHANGELOG.md
shahzad31 Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ No public interface changes since `13.7.0`.
- Fixed `EuiSwitch` semantics to align with aria roles ([#2193](https://github.com/elastic/eui/pull/2193))
- Removed Firefox's focus ring to match other browsers ([#2193](https://github.com/elastic/eui/pull/2193))
- Added missing `onChange` TS defs for EuiRange ([#2211](https://github.com/elastic/eui/pull/2211))
- Removed extra right side margin in 'EuiSuperDatePicker' ([#2236](https://github.com/elastic/eui/pull/2236))
- Fixed `EuiBadge` text cursor to default pointer ([#2234](https://github.com/elastic/eui/pull/2234))
- Fixed `EuiPageContent` className prop to allow the passed-in className to take cascade precedence over classes generated by the component ([#2237](https://github.com/elastic/eui/pull/2237))

Expand Down
5 changes: 4 additions & 1 deletion src/components/date_picker/super_date_picker/_super_date_picker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
.euiSuperDatePicker__flexWrapper {
max-width: 100%;
// Need to offset 8px because of negative margins added by small size gutter
max-width: calc(100% + #{$euiSizeS});
width: $euiSuperDatePickerWidth + $euiSuperDatePickerButtonWidth + $euiSizeS;
}

.euiSuperDatePicker__flexWrapper--isAutoRefreshOnly {
width: $euiFormMaxWidth;
max-width: 100%
}

.euiSuperDatePicker__flexWrapper--noUpdateButton {
width: $euiSuperDatePickerWidth;
max-width: 100%
}

.euiSuperDatePicker {
Expand Down