-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steps are styled #208
Steps are styled #208
Changes from 14 commits
3f36a32
1d7124e
c150655
38fba87
cf81499
e81ed86
0e7778e
be7c3cd
8af96ce
6b95cf2
d0f8bb7
35e25f0
3cea2bc
906a6bd
b446984
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,10 @@ import { | |
GuideSectionTypes, | ||
} from '../../components'; | ||
|
||
import { | ||
EuiCode, | ||
} from '../../../../src/components'; | ||
|
||
import Steps from './steps'; | ||
const stepsSource = require('!!raw-loader!./steps'); | ||
const stepsHtml = renderToHtml(Steps); | ||
|
@@ -33,7 +37,7 @@ export const StepsExample = { | |
demo: <Steps />, | ||
}, | ||
{ | ||
title: 'Heading Element Steps', | ||
title: 'Heading Elements', | ||
source: [{ | ||
type: GuideSectionTypes.JS, | ||
code: headingElementStepsSource, | ||
|
@@ -42,9 +46,17 @@ export const StepsExample = { | |
code: headingElementStepsHtml, | ||
}], | ||
text: ( | ||
<p> | ||
something something better accessibility | ||
</p> | ||
<div> | ||
<p> | ||
To aide with accessibility and hierachical headings, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think aide (noun) should be spelled "aid" (verb). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah... you might find that you catch a good amount spelling errors with me... I'm trying to be beter... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/beter/better 😹 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh and "hierachical" should be "hierarchical" |
||
you can and should pass in a heading element to use for each step title. | ||
The example below shows that the logical heading element should be an <EuiCode>h2</EuiCode> | ||
and therefore adds <EuiCode>headingElement="h2"</EuiCode> to the EuiSteps component. | ||
</p> | ||
<p> | ||
The style of the title will <strong>not</strong> be affected. | ||
</p> | ||
</div> | ||
), | ||
demo: <HeadingElementSteps />, | ||
}], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use sentence case?