-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Condensed Display Prop for EuiTabs & EuiTabbedContent #1904
Add Condensed Display Prop for EuiTabs & EuiTabbedContent #1904
Conversation
…tabs-update # Conflicts: # CHANGELOG.md
Congrats on your first PR! 🍾 @snide mentioned that you had a particular use case for this style of tabs. Could you elaborate on that? |
…tabs-update # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! The new prop was properly added, docs look good, SASS looks good, tests were added. Still need to:
- Add the new prop to the TS definitions file: https://github.com/elastic/eui/blob/ce11e65e4483069e05f5b1e306d765e779b304e9/src/components/tabs/index.d.ts
- Add a snippet to the docs example that showcases the quickest/shortest code a consumer would need to get this into their instance. We just started adding these and you can see an example on the Loading page:
snippet: `<EuiLoadingKibana size="m" />`
Styling
Do we think the underline is enough to indicate focus state?
In the default tabs we add a slight background color, same with empty buttons and links:
@cchaos would it be better to call the prop |
@chandlerprall |
Yeah, I also gave him the recommendation to use a display prop instead of the boolean. In retrospect we've shot ourselves in the foot for stylistic props as booleans that really should just be "alternate displays". Gives us flexibility for the next variation without conflict. |
…tabs-update # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had a request for the snippets and then I'd like either @thompsongl or @chandlerprall to give it a once-over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and docs changes LGTM
Looks like you're good to merge! |
Summary
This PR adds a new
display
prop to theEuiTabs
andEuiTabbedContent
components for the ability to use an alternativecondensed
style.The hope is to use the new prop to display a slightly more compact, bolder and borderless tabbed navigation for use as top-level navigation in the SIEM app. This alternative style gives the navigation more prominence than it currently has and also differentiates itself from other usages of tabs further down the page.
Checklist
[ ] This required updates to Framer X components