Misc. bugs and cleanup (#603)

* fix for focus state of disabled buttons #560 * allow select to pass any node as option, fixes #346
elastic · Mar 30, 2018 · d59b6b8 · d59b6b8
1 parent 75e4995
commit d59b6b8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # [`master`](https://github.com/elastic/eui/tree/master)
 
-No public interface changes since `0.0.37`.
+**Bug fixes**
+
+- Visual fix for the focus state of disabled `EuiButton` ([603](https://github.com/elastic/eui/pull/603))
+- `EuiSelect` can pass any node as a value rather than just a string ([603](https://github.com/elastic/eui/pull/603))
+
 
 # [`0.0.37`](https://github.com/elastic/eui/tree/v0.0.37)
 

diff --git a/src/components/button/_button.scss b/src/components/button/_button.scss
@@ -61,7 +61,6 @@
     }
 
     &:hover, &:focus {
-      background-color: $euiColorEmptyShade;
       text-decoration: none;
     }
   }

diff --git a/src/components/form/select/select.js b/src/components/form/select/select.js
@@ -82,7 +82,7 @@ EuiSelect.propTypes = {
   name: PropTypes.string,
   id: PropTypes.string,
   options: PropTypes.arrayOf(PropTypes.shape({
-    text: PropTypes.string.isRequired
+    text: PropTypes.node.isRequired
   })).isRequired,
   isInvalid: PropTypes.bool,
   fullWidth: PropTypes.bool,
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,7 +61,6 @@ @@
         }
         &:hover, &:focus {
-          background-color: $euiColorEmptyShade;
           text-decoration: none;
         }
       }
@@ Expand Down @@