Skip to content

Commit

Permalink
Upgrade Node to v16.17.1 (#6264)
Browse files Browse the repository at this point in the history
* Update Node version to 16.17.1 to match Kibana

* Update docker CI
  • Loading branch information
Constance authored Sep 28, 2022
1 parent 1384d0a commit c0b90a4
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .ci/jobs/elastic+eui+pull-request-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#!/usr/local/bin/runbld
export NVM_DIR="/var/lib/jenkins/.nvm"
[[ -s "$NVM_DIR/nvm.sh" ]] && . "$NVM_DIR/nvm.sh"
NODE_VERSION=16.16.0
NODE_VERSION=16.17.1
nvm install ${NODE_VERSION}
nvm use ${NODE_VERSION} --delete-prefix
npm run test-docker
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.16.0
16.17.1
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"main": "lib",
"module": "es",
"types": "eui.d.ts",
"docker_image": "node:16.16.0",
"docker_image": "node:16.17.1",
"sideEffects": [
"*.css",
"*.scss"
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/build_docs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

NODE_IMG="docker.elastic.co/eui/ci:3.2"
NODE_IMG="docker.elastic.co/eui/ci:3.3"

# Compile using node image
echo "Building docs using ${NODE_IMG} Docker image"
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/deploy_docs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ if [[ "$1" != "nodocker" ]]; then
--rm -i \
--volume $PWD:/app \
--workdir /app \
node:16.16.0 \
node:16.17.1 \
bash -c 'git tag | xargs npx semver' | tail -n 1)

# Run this script from inside the docker container, using google/cloud-sdk image
Expand Down
4 changes: 2 additions & 2 deletions scripts/docker-ci/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Derived from the zenato/puppeteer Docker image
# https://github.com/zenato/docker-puppeteer/blob/master/Dockerfile

# >=12.0 required (for cypress), but latest right now is 16.16.0
FROM node:16.16.0
# >=12.0 required (for cypress), but latest right now is 16.17.1
FROM node:16.17.1

# See https://crbug.com/795759
RUN apt-get update && apt-get install -yq libgconf-2-4
Expand Down
4 changes: 2 additions & 2 deletions scripts/test-docker.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
const { execSync } = require('child_process');

execSync('docker pull docker.elastic.co/eui/ci:3.2', {
execSync('docker pull docker.elastic.co/eui/ci:3.3', {
stdio: 'inherit',
});
/* eslint-disable-next-line no-multi-str */
execSync("docker run \
-i --rm --cap-add=SYS_ADMIN --volume=$(pwd):/app --workdir=/app \
-e GIT_COMMITTER_NAME=test -e GIT_COMMITTER_EMAIL=test -e HOME=/tmp \
--user=$(id -u):$(id -g) \
docker.elastic.co/eui/ci:3.2 \
docker.elastic.co/eui/ci:3.3 \
bash -c 'npm config set spin false \
&& /opt/yarn*/bin/yarn \
&& yarn cypress install \
Expand Down

0 comments on commit c0b90a4

Please sign in to comment.