Skip to content

Commit

Permalink
Revert grid background color (#4542)
Browse files Browse the repository at this point in the history
This reverts the background color of the data grid content. Although the light gray works well for loading states, it isn't a good experience for fixed height grids with a low amount of items. We'll solve the loading issue in a better way in 7.13. I'm leaving the scrollbar mixin as is because I think it will be useful in other spots.
  • Loading branch information
snide authored Feb 18, 2021
1 parent 015b7cd commit 4b5b261
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Added exports for all EUI component props matching `EuiComponentProps` name pattern. ([#4517](https://github.com/elastic/eui/pull/4517))
- Added `truncate`, `disabled`, and `emphasize` props to `EuiSideNavItem` ([#4488](https://github.com/elastic/eui/pull/4488))
- Added `truncate` prop to `EuiSideNav` ([#4488](https://github.com/elastic/eui/pull/4488))
- Reverted part of [#4509](https://github.com/elastic/eui/pull/4509) and returned `EuiDataGrid`'s background content area to an empty shade ([#4542](https://github.com/elastic/eui/pull/4542))

**Bug fixes**

Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/_data_grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
max-width: 100%;
width: 100%;
z-index: 2; // Sits above the pagination below it, but below the controls above it
background: $euiColorLightestShade;
background: $euiColorEmptyShade;
}

.euiDataGrid__controls {
Expand Down

0 comments on commit 4b5b261

Please sign in to comment.