Fixing opacities

elastic · Sep 18, 2018 · 3987934 · 3987934
1 parent 38d8bc9
commit 3987934
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/src/components/series_chart/series/__snapshots__/area_series.test.js.snap b/src/components/series_chart/series/__snapshots__/area_series.test.js.snap
@@ -832,7 +832,6 @@ exports[`EuiAreaSeries all props are rendered 1`] = `
                   onSeriesClick={[MockFunction]}
                   onSeriesMouseOut={[Function]}
                   onSeriesMouseOver={[Function]}
-                  opacity={1}
                   opacityDomain={Array []}
                   opacityType="literal"
                   radiusDomain={Array []}
@@ -857,6 +856,7 @@ exports[`EuiAreaSeries all props are rendered 1`] = `
                   style={
                     Object {
                       "cursor": "default",
+                      "opacity": 1,
                     }
                   }
                   xDomain={
@@ -1012,7 +1012,6 @@ exports[`EuiAreaSeries all props are rendered 1`] = `
                     onSeriesClick={[MockFunction]}
                     onSeriesMouseOut={[Function]}
                     onSeriesMouseOver={[Function]}
-                    opacity={1}
                     opacityDomain={Array []}
                     opacityType="literal"
                     radiusDomain={Array []}
@@ -1037,6 +1036,7 @@ exports[`EuiAreaSeries all props are rendered 1`] = `
                     style={
                       Object {
                         "cursor": "default",
+                        "opacity": 1,
                       }
                     }
                     xDomain={
@@ -1174,7 +1174,6 @@ exports[`EuiAreaSeries all props are rendered 1`] = `
                         onSeriesClick={[MockFunction]}
                         onSeriesMouseOut={[Function]}
                         onSeriesMouseOver={[Function]}
-                        opacity={1}
                         opacityDomain={Array []}
                         opacityType="literal"
                         radiusDomain={Array []}
@@ -1199,6 +1198,7 @@ exports[`EuiAreaSeries all props are rendered 1`] = `
                         style={
                           Object {
                             "cursor": "default",
+                            "opacity": 1,
                           }
                         }
                         xDomain={

diff --git a/src/components/series_chart/series/__snapshots__/line_series.test.js.snap b/src/components/series_chart/series/__snapshots__/line_series.test.js.snap
@@ -345,6 +345,7 @@ exports[`EuiLineSeries all props are rendered 1`] = `
                   strokeStyle="solid"
                   style={
                     Object {
+                      "opacity": 1,
                       "pointerEvents": "visiblestroke",
                       "strokeWidth": 3,
                     }
@@ -525,6 +526,7 @@ exports[`EuiLineSeries all props are rendered 1`] = `
                     strokeStyle="solid"
                     style={
                       Object {
+                        "opacity": 1,
                         "pointerEvents": "visiblestroke",
                         "strokeWidth": 3,
                       }
@@ -687,6 +689,7 @@ exports[`EuiLineSeries all props are rendered 1`] = `
                         strokeStyle="solid"
                         style={
                           Object {
+                            "opacity": 1,
                             "pointerEvents": "visiblestroke",
                             "strokeWidth": 3,
                           }
@@ -4463,6 +4466,7 @@ exports[`EuiLineSeries is rendered 1`] = `
                   strokeStyle="solid"
                   style={
                     Object {
+                      "opacity": 1,
                       "pointerEvents": "visiblestroke",
                       "strokeWidth": 3,
                     }
@@ -4641,6 +4645,7 @@ exports[`EuiLineSeries is rendered 1`] = `
                     strokeStyle="solid"
                     style={
                       Object {
+                        "opacity": 1,
                         "pointerEvents": "visiblestroke",
                         "strokeWidth": 3,
                       }
@@ -4801,6 +4806,7 @@ exports[`EuiLineSeries is rendered 1`] = `
                         strokeStyle="solid"
                         style={
                           Object {
+                            "opacity": 1,
                             "pointerEvents": "visiblestroke",
                             "strokeWidth": 3,
                           }

diff --git a/src/components/series_chart/series/_area_series.scss b/src/components/series_chart/series/_area_series.scss
@@ -1,4 +1,3 @@
 .euiAreaSeries {
-  stroke-width: 0;
-  opacity: .2 !important;
+  stroke-width: 0 !important;
 }
diff --git a/src/components/series_chart/series/area_series.js b/src/components/series_chart/series/area_series.js
@@ -65,13 +65,13 @@ export class EuiAreaSeries extends AbstractSeries {
           className="euiAreaSeries"
           curve={curve}
           color={color}
-          opacity={fillOpacity}
           data={data}
           onSeriesClick={onSeriesClick}
           onSeriesMouseOver={this._onSeriesMouseOver}
           onSeriesMouseOut={this._onSeriesMouseOut}
           style={{
             cursor: isMouseOverSeries && onSeriesClick ? 'pointer' : 'default',
+            opacity: fillOpacity,
           }}
           {...rest}
         />

diff --git a/src/components/series_chart/series/line_series.js b/src/components/series_chart/series/line_series.js
@@ -28,11 +28,11 @@ export class EuiLineSeries extends AbstractSeries {
           key={`${name}-border`}
           curve={curve}
           data={data}
-          opacity={borderOpacity}
           onSeriesClick={onSeriesClick}
           style={{
             pointerEvents: 'visiblestroke',
             strokeWidth: lineSize + 2, // border margin
+            opacity: borderOpacity,
           }}
           _colorValue={'white'}
         />