Fix bug

- need to call `onSearchChange` after matchingOptions state update in `getDerivedStateFromProps` runs, instead of before
elastic · Nov 1, 2023 · 352cf45 · 352cf45
1 parent f0ec473
commit 352cf45
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/components/combo_box/combo_box.tsx b/src/components/combo_box/combo_box.tsx
@@ -638,13 +638,14 @@ export class EuiComboBox<T> extends Component<
   ) => {
     const { onSearchChange, delimiter } = this.props;
 
-    if (onSearchChange) {
-      const hasMatchingOptions = this.state.matchingOptions.length > 0;
-      onSearchChange(searchValue, hasMatchingOptions);
-    }
-
     this.setState({ searchValue }, () => {
-      if (searchValue && this.state.isListOpen === false) this.openList();
+      if (searchValue && this.state.isListOpen === false) {
+        this.openList();
+      }
+      if (onSearchChange) {
+        const hasMatchingOptions = this.state.matchingOptions.length > 0;
+        onSearchChange(searchValue, hasMatchingOptions);
+      }
     });
     if (delimiter && searchValue.endsWith(delimiter)) {
       this.setCustomOptions(false);