undoes String cast per review feedback

elastic · Feb 7, 2020 · 04fceba · 04fceba
1 parent 2310a4f
commit 04fceba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/code/__snapshots__/code_block.test.tsx.snap b/src/components/code/__snapshots__/code_block.test.tsx.snap
@@ -142,11 +142,11 @@ console.log(some);
 exports[`EuiCodeBlock props overflowHeight is rendered 1`] = `
 <div
   class="euiCodeBlock euiCodeBlock--fontSmall euiCodeBlock--paddingLarge euiCodeBlock--hasControls"
-  style="max-height: 200;"
+  style="max-height: 200px;"
 >
   <pre
     class="euiCodeBlock__pre"
-    style="max-height: 200;"
+    style="max-height: 200px;"
   >
     <code
       class="euiCodeBlock__code"

diff --git a/src/components/code/_code_block.tsx b/src/components/code/_code_block.tsx
@@ -174,7 +174,7 @@ export class EuiCodeBlockImpl extends Component<Props, State> {
     const optionalStyles: CSSProperties = {};
 
     if (overflowHeight) {
-      optionalStyles.maxHeight = String(overflowHeight);
+      optionalStyles.maxHeight = overflowHeight;
     }
 
     const codeSnippet = (