Fix downsample failure when FLS/DLS is enabled. #98587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If FLS/DLS is enabled (this is the case when trial/licence is active and security is enabled) then invoking the downsample API results in immediate failure. The downsample shard persistent task executor opens a searcher, but security didn't set indices permissions in the thread local (this happens via SecurityActionFilter). This will only happen on indices actions (which are actions with a request that implement IndicesRequest. This change does this by delegating to a transport action that executes always locally, and this way security prepares thread local headers correctly. This adds another layer of indirection, but without doing this FLS/DLS wouldn't work. Closes elastic#98569
martijnvg
added
>non-issue
:StorageEngine/Downsampling
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
kkrik-es
reviewed
Aug 17, 2023
| - match: { hits.hits.0._source.k8s.pod.values: [1, 1, 3] } | ||
| - is_true: hits.hits.0._source.k8s.pod.running | ||
|
|
||
| # Assert rollup index settings |
kkrik-es
approved these changes
Aug 17, 2023
martijnvg
added
auto-merge-without-approval
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Aug 17, 2023
If FLS/DLS is enabled (this is the case when trial/licence is active and security is enabled) then invoking the downsample API results in immediate failure. The downsample shard persistent task executor opens a searcher, but security didn't set indices permissions in the thread local (this happens via SecurityActionFilter). This will only happen on indices actions (which are actions with a request that implement IndicesRequest. This change does this by delegating to a transport action that executes always locally, and this way security prepares thread local headers correctly. This adds another layer of indirection, but without doing this FLS/DLS wouldn't work. Closes elastic#98569 (Marking as a non-issue, because this a bug in not released code)
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 17, 2023
If FLS/DLS is enabled (this is the case when trial/licence is active and security is enabled) then invoking the downsample API results in immediate failure. The downsample shard persistent task executor opens a searcher, but security didn't set indices permissions in the thread local (this happens via SecurityActionFilter). This will only happen on indices actions (which are actions with a request that implement IndicesRequest. This change does this by delegating to a transport action that executes always locally, and this way security prepares thread local headers correctly. This adds another layer of indirection, but without doing this FLS/DLS wouldn't work. Closes #98569 (Marking as a non-issue, because this a bug in not released code)
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 18, 2023
If FLS/DLS is enabled (this is the case when trial/licence is active and security is enabled) then invoking the downsample API results in immediate failure. The downsample shard persistent task executor opens a searcher, but security didn't set indices permissions in the thread local (this happens via SecurityActionFilter). This will only happen on indices actions (which are actions with a request that implement IndicesRequest. This change does this by delegating to a transport action that executes always locally, and this way security prepares thread local headers correctly. This adds another layer of indirection, but without doing this FLS/DLS wouldn't work. Closes elastic#98569 (Marking as a non-issue, because this a bug in not released code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If FLS/DLS is enabled (this is the case when trial/licence is active and security is enabled) then invoking the downsample API results in immediate failure.
The downsample shard persistent task executor opens a searcher, but security didn't set indices permissions in the thread local (this happens via SecurityActionFilter). This will only happen on indices actions (which are actions with a request that implement IndicesRequest. This change does this by delegating to a transport action that executes always locally, and this way security prepares thread local headers correctly.
This adds another layer of indirection, but without doing this FLS/DLS wouldn't work.
Closes #98569
(Marking as a non-issue, because this a bug in not released code)