Refactor IngestDocument reroute recursion detection #95350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add a comment explaining why that is.
More like how we handle e.g. executedPipelines.
joegallo
added
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Is there a way to access the index history from a processor so that users can use, for example, a Something like - set:
field: reroute_history
copy_from: _ingest.index_history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #94000
Rather than tracking the
indexRecursionDetectionin the recursive calls toexecutePipelines(...), I've moved it into theIngestDocumentitself asindexHistory.Note:
FinalPipelineIT(untouched by this PR) covers the case of us rejecting a document where the pipelines attempt to create an index cycle.Among other things, I think it would make it easier in the future to track the values of the
_indexas they change via pipeline execution (useful for the simulate API, I imagine), but this PR doesn't make any changes along those lines.