Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Add multi-node tests for checking transform permissions #93855

Merged
merged 3 commits into from
Mar 2, 2023
Merged

[Transform] Add multi-node tests for checking transform permissions #93855

merged 3 commits into from
Mar 2, 2023

Conversation

przemekwitek
Copy link
Contributor

This PR adds integration multi-node tests that verify a bunch of scenarios in which the transform:

  1. is created by the user that is lacking permissions to source/dest indices
  2. something (PUT/_start or health) doesn't work depending on additional settings (defer_validation, unattended)
  3. is updated by the user that has all the required permissions
  4. now operates successfully

Relates #93259

@przemekwitek przemekwitek force-pushed the transform_permission branch 2 times, most recently from 908ddff to 677df60 Compare February 16, 2023 12:36
@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-2

@przemekwitek przemekwitek marked this pull request as ready for review February 16, 2023 16:49
@przemekwitek przemekwitek added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform labels Feb 16, 2023
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Feb 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/bwc

hendrikmuhs
hendrikmuhs approved these changes Feb 28, 2023
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

droberts195
droberts195 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 75e482c into elastic:main Mar 2, 2023
@przemekwitek przemekwitek deleted the transform_permission branch March 2, 2023 07:10
@przemekwitek przemekwitek mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@przemekwitek @elasticsearchmachine @hendrikmuhs @droberts195