Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Make it possible to clear retention policy on an existing transform #82703

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[Transform] Make it possible to clear retention policy on an existing transform #82703

merged 2 commits into from
Jan 25, 2022

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Jan 18, 2022 •
edited
Loading

Until now, it was possible to update retention policy but not to remove it.

This PR makes it possible to remove/clear a retention policy from an existing transform.

Fixes #82560

@przemekwitek przemekwitek force-pushed the remove_retention_policy branch 4 times, most recently from bda75b3 to 271e296 Compare January 18, 2022 15:03
@przemekwitek przemekwitek changed the title [Transform] Make it possible to clear retention policy [Transform] Make it possible to clear retention policy on an existing transform Jan 18, 2022
@przemekwitek przemekwitek force-pushed the remove_retention_policy branch from 271e296 to 40b0cb7 Compare January 18, 2022 15:08
@przemekwitek przemekwitek removed the WIP label Jan 18, 2022
@przemekwitek przemekwitek marked this pull request as ready for review January 18, 2022 15:10
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jan 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@przemekwitek
Copy link
Contributor Author

I realized that there is a bug when the update request is serialized over wire. I'll update the PR once this is fixed.

@przemekwitek przemekwitek force-pushed the remove_retention_policy branch from 82a40bc to 5699dcf Compare January 19, 2022 08:26
@przemekwitek
Copy link
Contributor Author

I realized that there is a bug when the update request is serialized over wire. I'll update the PR once this is fixed.

Ok, this is done now.

hendrikmuhs
hendrikmuhs approved these changes Jan 25, 2022
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek mentioned this pull request Jan 25, 2022
Closed
@przemekwitek
Copy link
Contributor Author

@elastic/ml-ui : I've just created a Kibana issue for this: elastic/kibana#123691

@przemekwitek przemekwitek merged commit 7efce30 into elastic:master Jan 25, 2022
@przemekwitek przemekwitek deleted the remove_retention_policy branch January 25, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Assignees
No one assigned
Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Transform] ability to remove retention_policy
4 participants
@przemekwitek @elasticmachine @hendrikmuhs @elasticsearchmachine