Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reroute processor #76511
Add reroute processor #76511
Changes from 26 commits
2d80949
1ede9bc
eba46c6
39b57ee
6751fc2
3e25d0e
c31b51f
ac5f282
d4bc1ad
afa1527
c76d5da
b514a6c
6c44e35
4888843
26b3c79
88a7d2a
2d02830
584f8c5
60df140
a312432
7dbd47e
c8cdaae
24aaab9
19344bb
1d454b6
5904db6
d043ae3
b2b9e7a
d5491de
e3c3ad1
7cc0a99
7647f9e
e43ac5f
0ef9503
7553638
c49e70b
0c29f73
55177e1
e13451e
dbb7dd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a
*
and write it below just once? There you could also add the invalid chars list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to describe a little bit more around how this if condition work. Why
ctx
is there and all the?
. If you are not used to write ingest pipeline (conditions), this might not be obvious. I would do a very quick description here and then link to the ES docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs contain a description of the
if
option and a link to the corresponding docs. Isn't that enough?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we do in most places of our docs and I really don't like it. The link is important but for a user to be successful, a user should not have to jump through 3 doc pages to get a single task completed. Instead I would rather repeat some of the docs that the basic use case is all covered in on flow.