Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose dynamic_templates parameter in Ingest #71716

Merged
merged 8 commits into from
Apr 19, 2021
Merged

Expose dynamic_templates parameter in Ingest #71716

merged 8 commits into from
Apr 19, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 15, 2021

This change exposes the newly introduced parameter dynamic_templates in ingest. This parameter can be set by a set processor or a script processor (see the YAML test).

Relates #69948

@dnhatn dnhatn added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.13.0 labels Apr 15, 2021
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Search Meta label for search team labels Apr 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn
Copy link
Member Author

dnhatn commented Apr 15, 2021

/cc @javanna @axw

javanna
javanna reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment on behaviour and docs. The change makes sense to me.

@dnhatn dnhatn requested a review from javanna April 15, 2021 18:03
javanna
javanna approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small comment on docs, LGTM otherwise

@dnhatn
Copy link
Member Author

dnhatn commented Apr 19, 2021

@javanna Thanks for reviewing.

@dnhatn dnhatn merged commit 46ada22 into elastic:master Apr 19, 2021
@dnhatn dnhatn deleted the ingest-script branch April 19, 2021 15:34
@dnhatn dnhatn mentioned this pull request Apr 19, 2021
Merged
dnhatn added a commit that referenced this pull request Apr 19, 2021
@dnhatn
Expose dynamic_templates parameter in Ingest (#71716)
d6f176e 
This change exposes the newly introduced parameter dynamic_templates
in ingest. This parameter can be set by a set processor or a script processor.

Relates #69948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Data Management Meta label for data/management team Team:Search Meta label for search team v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnhatn @elasticmachine @javanna @jakelandis