Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adding page for indexing runtime fields #71366

Merged
merged 4 commits into from
Apr 7, 2021
Merged

[DOCS] Adding page for indexing runtime fields #71366

merged 4 commits into from
Apr 7, 2021

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Apr 6, 2021 •
edited
Loading

@lockewritesdocs lockewritesdocs added the >docs General docs changes label Apr 6, 2021
@lockewritesdocs lockewritesdocs self-assigned this Apr 6, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Apr 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lockewritesdocs lockewritesdocs added :Search Foundations/Mapping Index mappings, including merging and defining field types v7.13.0 v8.0.0 labels Apr 6, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Apr 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

javanna
javanna approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment but LGTM. Shall we mention that scripts are not editable on the properties side of things, and possibly the on_script_error behaviour?

nik9000
nik9000 reviewed Apr 7, 2021
View reviewed changes
@lockewritesdocs lockewritesdocs merged commit 343c52c into elastic:master Apr 7, 2021
@lockewritesdocs lockewritesdocs deleted the docs__indexed-runtime-fields branch April 7, 2021 17:07
@lockewritesdocs lockewritesdocs mentioned this pull request Apr 7, 2021
Merged
lockewritesdocs pushed a commit that referenced this pull request Apr 7, 2021
[DOCS] [7.x] Adding page for indexing runtime fields #71366 (#71431)
d0d5376 
* [DOCS] Adding page for indexing runtime fields (#71366)

* [DOCS] Adding page for indexing runtime fields

* Fixing tests.

* Incorporating review feedback to enhance and improve examples.

* Changing note to indicate immutable script when indexing, plus adding on_script_error.

* Add type to responses for 7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 left review comments

@javanna javanna javanna approved these changes

Assignees

@lockewritesdocs lockewritesdocs

Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Add docs for moving runtime field definitions to index mapping
5 participants
@lockewritesdocs @elasticmachine @nik9000 @javanna @jakelandis