Add fleet polling API for global checkpoint #71093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>enhancement
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| final ActionListener<Response> listener) { | ||
| try { | ||
| super.asyncShardOperation(request, shardId, listener); | ||
| } catch (final IOException caught) { |
There was a problem hiding this comment.
Would be nice to just drop that from the signature of asyncShardOperation, perhaps in a separate PR.
There was a problem hiding this comment.
Yeah probably follow-up.
...ugin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointAction.java
Outdated
Show resolved
Hide resolved
...ugin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointAction.java
Outdated
Show resolved
Hide resolved
...n/fleet/src/main/java/org/elasticsearch/xpack/fleet/rest/RestGetGlobalCheckpointsAction.java
Show resolved
Hide resolved
2 tasks
...gin/fleet/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/fleet/global_checkpoints.yml
Outdated
Show resolved
Hide resolved
...ugin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointAction.java
Outdated
Show resolved
Hide resolved
...gin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointsAction.java
Show resolved
Hide resolved
...gin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointsAction.java
Show resolved
Hide resolved
...gin/fleet/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/fleet/global_checkpoints.yml
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/fleet.global_checkpoints.json
Outdated
Show resolved
Hide resolved
rest-api-spec/src/main/resources/rest-api-spec/api/fleet.global_checkpoints.json
Outdated
Show resolved
Hide resolved
|
Tested with Fleet Server changes to utilize the new API. All works as expected. Thank you! |
| @@ -0,0 +1,13 @@ | |||
| [role="xpack"] | |||
There was a problem hiding this comment.
The preview diff from the docs build did not include this. I think you need to add it to index.asciidoc too to get it on the main page and thus included into the docs output.
There was a problem hiding this comment.
I still do not see it in the preview. I think a link is still missing here:
similar to the one for CCR.
...gin/fleet/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/fleet/global_checkpoints.yml
Show resolved
Hide resolved
x-pack/plugin/fleet/src/internalClusterTest/java/fleet/action/GetGlobalCheckpointsActionIT.java
Outdated
Show resolved
Hide resolved
...gin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointsAction.java
Outdated
Show resolved
Hide resolved
...gin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointsAction.java
Show resolved
Hide resolved
...gin/fleet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointsAction.java
Outdated
Show resolved
Hide resolved
...leet/src/main/java/org/elasticsearch/xpack/fleet/action/GetGlobalCheckpointsShardAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/fleet/src/internalClusterTest/java/fleet/action/GetGlobalCheckpointsActionIT.java
Outdated
Show resolved
Hide resolved
henningandersen
approved these changes
Apr 14, 2021
| @Override | ||
| public List<ActionHandler<? extends ActionRequest, ? extends ActionResponse>> getActions() { | ||
| return Arrays.asList( | ||
| new ActionHandler<>(GetGlobalCheckpointsAction.INSTANCE, GetGlobalCheckpointsAction.TransportGetGlobalCheckpointsAction.class), |
There was a problem hiding this comment.
nit: just for consistency we should rename this to just TransportAction too? Completely optional.
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleet server needs an API to access up to date global checkpoints for
indices. Additionally, it requires a mode of operation when fleet can
provide its current knowledge about the global checkpoints and poll for
advancements. This commit introduces this API in the fleet plugin.