Support fetching flattened subfields #70916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `fields` API fetches the root flattened field and returns it in a structured way in the response. In addition this change makes it possible to directly query subfields. However, requesting flattened subfields via wildcard patterns is not possible. Closes elastic#70605
cbuescher
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
commented
Mar 26, 2021
server/src/main/java/org/elasticsearch/index/mapper/FieldTypeLookup.java
Show resolved
Hide resolved
romseygeek
reviewed
Mar 26, 2021
server/src/main/java/org/elasticsearch/index/mapper/flattened/FlattenedFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/FieldTypeLookup.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
jtibshirani
reviewed
Apr 13, 2021
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/flattened/FlattenedFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/mapper/flattened/KeyedFlattenedFieldTypeTests.java
Show resolved
Hide resolved
|
@jtibshirani thanks, I think I adressed your change requests and added a unit and a yaml test. I think I will also add a short passage to the docs somewhere about fetching flattened subfields and that the naming has to be exact, I haven't found a good spot yet though. Will be back with another short update shortly. |
jtibshirani
approved these changes
Apr 14, 2021
| @@ -325,6 +325,77 @@ will return only the users first name but still maintain the structure of the ne | |||
| However, when the `fields` pattern targets the nested `user` field directly, no | |||
| values will be returned since the pattern doesn't match any leaf fields. | |||
|
|
|||
| [discrete] | |||
| [[search-fields-flattened]] | |||
| ==== Handling of flattened fields | |||
There was a problem hiding this comment.
It would be nice to move this to the flattened field type documentation. That would help keep this high-level documentation streamlined and easy to approach.
| @@ -261,8 +263,7 @@ public BytesRef indexedValueForSearch(Object value) { | |||
|
|
|||
| @Override | |||
| public ValueFetcher valueFetcher(SearchExecutionContext context, String format) { | |||
There was a problem hiding this comment.
I just realized we should throw an error if the format is non-null, as we do for most other field types. (This is unfortunately very manual right now and easy to forget...)
added 2 commits
April 14, 2021 21:34
romseygeek
approved these changes
Apr 15, 2021
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Apr 15, 2021
Currently the `fields` API fetches the root flattened field and returns it in a structured way in the response. In addition this change makes it possible to directly query subfields. However, requesting flattened subfields via wildcard patterns is not possible. Closes elastic#70605
cbuescher
pushed a commit
that referenced
this pull request
Apr 15, 2021
Currently the `fields` API fetches the root flattened field and returns it in a structured way in the response. In addition this change makes it possible to directly query subfields. However, requesting flattened subfields via wildcard patterns is not possible. Closes #70605
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
fieldsAPI fetches the root flattened field and returns it in astructured way in the response. In addition this change makes it possible to
directly query subfields. However, requesting flattened subfields via wildcard
patterns is not possible.
Closes #70605