Take the node id into account when creating geoip tmp dir. #70462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adjust where the geoip tmp directory is created to avoid issues when running multiple nodes on the same machine. In the java tmp dir, a 'geoip-databases' directory is created and directly under this directory a directory with the node id as name is created. This allows safely running multiple nodes on the same machine (this happens mainly during tests). Closes elastic#69972 Relates to elastic#68920
martijnvg
added
>non-issue
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
probakowski
approved these changes
Mar 17, 2021
| throw new UncheckedIOException(e); | ||
| } | ||
| }).filter(path -> { | ||
| return StreamSupport.stream(clusterService().state().nodes().getDataNodes().values().spliterator(), false) |
There was a problem hiding this comment.
Maybe extract data nodes ids to local variable?
Set<String> ids = StreamSupport.stream(clusterService().state().nodes().getDataNodes().values().spliterator(), false)
.map(c -> c.value.getId())
.collect(Collectors.toSet());
final List<Path> geoipTmpDirs = ...
}).filter(path -> ids.contains(path.getFileName().toString()))
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Mar 17, 2021
Backport elastic#70462 to 7.x branch. This change adjust where the geoip tmp directory is created to avoid issues when running multiple nodes on the same machine. In the java tmp dir, a 'geoip-databases' directory is created and directly under this directory a directory with the node id as name is created. This allows safely running multiple nodes on the same machine (this happens mainly during tests). Closes elastic#69972 Relates to elastic#68920
martijnvg
added a commit
that referenced
this pull request
Mar 17, 2021
Backport #70462 to 7.x branch. This change adjust where the geoip tmp directory is created to avoid issues when running multiple nodes on the same machine. In the java tmp dir, a 'geoip-databases' directory is created and directly under this directory a directory with the node id as name is created. This allows safely running multiple nodes on the same machine (this happens mainly during tests). Closes #69972 Relates to #68920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adjust where the geoip tmp directory is created
to avoid issues when running multiple nodes on the same machine.
In the java tmp dir, a 'geoip-databases' directory is created and
directly under this directory a directory with the node id as name is created.
This allows safely running multiple nodes on the same machine (this
happens mainly during tests).
Closes #69972
Relates to #68920