Fix rollover alias definition in templates validation #70259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail.
andreidan
added
>bug
:Data Management/Indices APIs
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
approved these changes
Mar 10, 2021
| MetadataRolloverService.checkNoDuplicatedAliasInIndexTemplate(metadata, indexName, aliasName, randomBoolean()); | ||
| // success | ||
| } catch (Exception e) { | ||
| fail("the valid v2 template takes priority over the v1 template. was not expecting a failure but got: " + e.getMessage()); |
There was a problem hiding this comment.
We probably don't need to catch this exception, since uncaught exceptions would cause the test to fail anyway. This also swallows the stacktrace which would make it slightly harder to investigate for someone triaging a failure.
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Mar 11, 2021
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail. (cherry picked from commit 3ea34bf) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Mar 11, 2021
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail. (cherry picked from commit 3ea34bf) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Mar 11, 2021
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail. (cherry picked from commit 3ea34bf) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Mar 11, 2021
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail. (cherry picked from commit 3ea34bf) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Mar 11, 2021
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail. (cherry picked from commit 3ea34bf) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Mar 11, 2021
…#70301) This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail. (cherry picked from commit 3ea34bf) Signed-off-by: Andrei Dan <[email protected]>
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Mar 15, 2021
This fixes the case where a valid composable template overrides/shadows a legacy template that defines the rollover alias. This is a valid configuration and rollover should not fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where a valid composable template overrides/shadows a
legacy template that defines the rollover alias. This is a valid configuration
and rollover should not fail.
Fixes #70258