-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network direction processor additions #68712
Network direction processor additions #68712
Conversation
Pinging @elastic/es-core-features (Team:Core/Features) |
@andrewstucki, can you update this PR with the new location of these files to resolve the merge conflicts? |
fd167b6
to
cf6701a
Compare
@danhermann sorry about the delay, this should be up-to-date now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @andrewstucki. This looks pretty good although I think there are some simplifications that can be made as noted below.
...s/ingest-common/src/main/java/org/elasticsearch/ingest/common/NetworkDirectionProcessor.java
Outdated
Show resolved
Hide resolved
...s/ingest-common/src/main/java/org/elasticsearch/ingest/common/NetworkDirectionProcessor.java
Show resolved
Hide resolved
...s/ingest-common/src/main/java/org/elasticsearch/ingest/common/NetworkDirectionProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewstucki, two small requests here and then we can merge this. Can you add a test in NetworkDirectionProcessorFactoryTests
that validates the internal_networks_field
option for the processor. And then one other small request below.
...mon/src/test/java/org/elasticsearch/ingest/common/NetworkDirectionProcessorFactoryTests.java
Show resolved
Hide resolved
Thanks, @andrewstucki. I'll get this merged and backported. |
cc: @elastic/es-ui in case auto-complete needs to be updated to accommodate this new option. |
This adds some functionality to the new
network_direction
processor that allows the processor to use templates for specifyinginternal_networks
or to read the values as an array from a given field. This is important because it allows for dynamic processor execution based on the contents of a given field. We actually use this internally in a number of beats modules where we pass configuration from a configuration file up to a pipeline on the document being ingested--the processor then gets executed based off of that extra configuration context prior to the fields being dropped.One of my first desired use cases is in the cisco umbrella filebeat module where I'm planning to add the following to the pipeline: