Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncSearchActionIT#testRestartAfterCompletion #63211

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 2, 2020

We need to complete the search before closing the iterator, which internally closes the point in time; otherwise, the search will fail with a missing context error.

Closes #62451

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Oct 2, 2020
@dnhatn dnhatn requested a review from jimczi October 2, 2020 19:34
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 2, 2020
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnhatn dnhatn merged commit 1fe287d into elastic:master Oct 2, 2020
@dnhatn dnhatn deleted the fix-async-pit branch October 2, 2020 21:31
dnhatn added a commit that referenced this pull request Oct 2, 2020
We need to complete the search before closing the iterator, which 
internally closes the point in time; otherwise, the search will fail
with a missing context error.

Closes #62451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] AsyncSearchActionIT.testRestartAfterCompletion failures
4 participants