Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] EQL: Clarify until keyword docs #61794

Merged
merged 3 commits into from
Sep 1, 2020
Merged

[DOCS] EQL: Clarify until keyword docs #61794

merged 3 commits into from
Sep 1, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Sep 1, 2020 •
edited
Loading

Changes:

  • Revises the until keyword content for clarity
  • Simplifies and replaces the until example
  • Updates the examples in the PID tip to follow ECS

Preview

https://elasticsearch_61794.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/eql-syntax.html#eql-until-keyword

@jrodewig jrodewig changed the title [DOCS] Clarify until keyword docs [DOCS] EQL: Clarify until keyword docs Sep 1, 2020
@jrodewig jrodewig added :Analytics/EQL EQL querying >docs General docs changes v7.10.0 v7.9.2 v8.0.0 labels Sep 1, 2020
rw-access
rw-access reviewed Sep 1, 2020
View reviewed changes
docs/reference/eql/syntax.asciidoc
Matching sequences must end before this event, which is not included the
results. If this event occurs within a sequence, the sequence is not considered
a match.
You can use the `until` keyword to specify an expiration event for a sequence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you @jrodewig!

@jrodewig jrodewig marked this pull request as ready for review September 1, 2020 15:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Sep 1, 2020
rw-access
rw-access approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dgieselaar
dgieselaar approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Super helpful changes.

@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 1, 2020

Thanks @rw-access @dgieselaar!

@jrodewig jrodewig merged commit 21deb3b into elastic:master Sep 1, 2020
@jrodewig jrodewig deleted the docs__eql-fix-until branch September 1, 2020 17:37
This was referenced Sep 1, 2020
Merged
Merged
jrodewig added a commit that referenced this pull request Sep 1, 2020
@jrodewig
[DOCS] EQL: Clarify until keyword docs (#61794) (#61808)
fd976e6
jrodewig added a commit that referenced this pull request Sep 1, 2020
@jrodewig
[DOCS] EQL: Clarify until keyword docs (#61794) (#61809)
083627f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@rw-access rw-access rw-access approved these changes

Assignees
No one assigned
Labels
:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.9.2 v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrodewig @elasticmachine @dgieselaar @rw-access @jakelandis