Scripting: Converts casting and def support #61350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Painless will cast returned values to a converter argument type, if necessary. Painless will also look for a special `convertFromDef` converter which is called to explicitly handle `def` conversions. `convertFromDef` must handle all valid def conversions. Refs: elastic#59647
stu-elastic
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
stu-elastic
commented
Aug 19, 2020
modules/lang-painless/src/main/java/org/elasticsearch/painless/ScriptClassInfo.java
Show resolved
Hide resolved
|
@stu-elastic could you add version labels to this PR please? |
|
it will be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Painless will cast returned values to a converter
argument type, if necessary.
Painless will also look for a special
convertFromDefconverter which is called to explicitly handle
defconversions.
convertFromDefmust handle all valid def conversions.Refs: #59647