Allow null name when deserialising API key document #59485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
|
Pinging @elastic/es-security (:Security/Authentication) |
ywangd
commented
Jul 14, 2020
| int version, | ||
| @Nullable BytesReference roleDescriptorsBytes, | ||
| BytesReference roleDescriptorsBytes, |
There was a problem hiding this comment.
Removed Nullable and replaced optionalConstructorArg() with constructorArg() for hash and roleDescriptorsBytes fields for clarity:
- The parser does not allow them to be null without something like
builder.declareStringOrNull(...). Therefore theNullableetc does not have any effects anyway. In another word, the overall code logic is not impacted. - Based on the logic in
ApiKeyService#newDocument, these two fields can never be null.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 14, 2020
API keys can be created without names using grant API key action. This is considered as a bug (elastic#59484). Since the feature has already been released, we need to accomodate existing keys that are created with null names. This PR relaxes the parser logic so that a null name is accepted.
ywangd
added a commit
that referenced
this pull request
Jul 14, 2020
API keys can be created without names using grant API key action. This is considered as a bug (#59484). Since the feature has already been released, we need to accomodate existing keys that are created with null names. This PR relaxes the parser logic so that a null name is accepted.
|
Auditing also doesn't expect API keys with |
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API keys can be created without names using grant API key action. This is considered as a bug (#59484). Since the feature has already been released, we need to accomodate existing keys that are created with null names. This PR relaxes the parser logic so that a
nullname is accepted.Resolves: #59481